Update download page to use stack unpack #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has two main benefits over what we have currently: It means that people end up using the same install plan that we use in the binaries; currently, encouraging people to use nightly resolvers will mean that they sometimes get new versions of libraries we depend on, resulting in a set of dependencies which we haven't run the compiler test suite with, or even used together. It also means that people aren't limited to only those versions of purescript which have made it into a nightly version. For example, when we depend on some other package which isn't yet in the nightly snapshots (for example, because not everything in the snapshot works with its newer versions yet), that version of purescript would not be installable. By contrast, this approach will work for any version of PureScript which is on Hackage.
Collaborator
Author
|
😍 |
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has two main benefits over what we have currently:
It means that people end up using the same install plan that we use in
the binaries; currently, encouraging people to use nightly resolvers
will mean that they sometimes get new versions of libraries we depend
on, resulting in a set of dependencies which we haven't run the compiler
test suite with, or even used together.
It also means that people aren't limited to only those versions of
purescript which have made it into a nightly version. For example, when
we depend on some other package which isn't yet in the nightly snapshots
(for example, because not everything in the snapshot works with its
newer versions yet), that version of purescript would not be
installable. By contrast, this approach will work for any version of
PureScript which is on Hackage.